Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put phil strings inside functions #2133

Merged
merged 3 commits into from
Jun 9, 2022
Merged

put phil strings inside functions #2133

merged 3 commits into from
Jun 9, 2022

Conversation

dwpaley
Copy link
Contributor

@dwpaley dwpaley commented Jun 8, 2022

Wouldn't it be nice if your editor would fold phil strings? Then you wouldn't have to scroll past hundreds of lines at the top of a file. Yes, that would be nice.

I've just done this for stills_process, but if this idea is appreciated, then I could make a more comprehensive effort.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #2133 (21d303f) into main (2083927) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 21d303f differs from pull request most recent head c16f7cf. Consider uploading reports for the commit c16f7cf to get more accurate results

@@           Coverage Diff           @@
##             main    #2133   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         583      583           
  Lines       66121    66127    +6     
  Branches     9317     9317           
=======================================
+ Hits        53253    53258    +5     
- Misses      10821    10822    +1     
  Partials     2047     2047           

@ndevenish
Copy link
Member

I think if we were going to do this more generally, it might be better to consider a "library module" of places that we store the PHIL configuration in. But no objections to making the stills_process code easier to navigate 😃

@ndevenish ndevenish merged commit ecd6bf8 into main Jun 9, 2022
@ndevenish ndevenish deleted the fold_phil branch June 9, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants