Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LevMar: terminate with zero expected objective decrease #2135

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Jun 13, 2022

Avoid divide-by-zero in the special case of starting refinement already at the minimum.

Avoid a divide-by-zero, encountered in ssx_reduction tests
Copy link
Contributor

@jbeilstenedmands jbeilstenedmands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@ndevenish ndevenish merged commit 6262531 into main Jun 13, 2022
@ndevenish ndevenish deleted the zero-expected-decrease branch June 13, 2022 14:11
ndevenish pushed a commit that referenced this pull request Jun 13, 2022
Check for zero expected decrease of the objective.

Avoid a divide-by-zero, encountered in ssx_reduction tests
ndevenish pushed a commit that referenced this pull request Jun 13, 2022
Check for zero expected decrease of the objective.

Avoid a divide-by-zero, encountered in ssx_reduction tests
This was referenced Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants