Unify reference scaling options in dials.scale #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2148 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 585 585
Lines 66207 66207
Branches 9335 9340 +5
=======================================
+ Hits 53351 53353 +2
- Misses 10801 10803 +2
+ Partials 2055 2051 -4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a
target_mtz=and atarget_model=option. Combine these into a more generalreference=option, which also covers a new case of a reference cif data file, and deprecate the use oftarget_mtzandtarget_model(but leave them in for now). Add some extra tests to cover previously untested paths for reference files.Make use of the new module created in #2144 and further unify some of the scaling code for determining reference datastructures from a model/data file.