Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete polygon mask when saving parameters #2150

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Complete polygon mask when saving parameters #2150

merged 5 commits into from
Jul 21, 2022

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Jun 22, 2022

If the user is creating a polygon mask they previously had to click on a different mode (e.g. Circle) to complete the mask description, before clicking on Save mask.phil, otherwise an empty mask description was written out.

This change resolves that, by forcing the polygon values to be added when OnUpdate is called, and then calling OnUpdate when the Save button is clicked.

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #2150 (09c8f6e) into main (178236f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2150   +/-   ##
=======================================
  Coverage   80.63%   80.64%           
=======================================
  Files         587      587           
  Lines       66417    66417           
  Branches     9357     9357           
=======================================
+ Hits        53557    53562    +5     
+ Misses      10804    10802    -2     
+ Partials     2056     2053    -3     

@dagewa dagewa merged commit 2231903 into main Jul 21, 2022
@dagewa dagewa deleted the polygon-mask-save branch July 21, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants