dials.cosym: don't apply cb_op to crystal twice #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug appears to have been introduced in #1647. Since it was only the crystal model, and not the miller indices, that were affected, I don't think it should cause any problems in most cases, although it may affect the resulting unit cells in cases of pseudo-symmetry. Co-authored-by: James Beilsten-Edmands <30625594+jbeilstenedmands@users.noreply.github.com>
jbeilstenedmands
approved these changes
Jun 23, 2022
ndevenish
pushed a commit
that referenced
this pull request
Jul 12, 2022
This bug appears to have been introduced in #1647. Since it was only the crystal model, and not the miller indices, that were affected, I don't think it should cause any problems in most cases, although it may affect the resulting unit cells in cases of pseudo-symmetry. Co-authored-by: James Beilsten-Edmands <30625594+jbeilstenedmands@users.noreply.github.com>
ndevenish
pushed a commit
that referenced
this pull request
Jul 12, 2022
This bug appears to have been introduced in #1647. Since it was only the crystal model, and not the miller indices, that were affected, I don't think it should cause any problems in most cases, although it may affect the resulting unit cells in cases of pseudo-symmetry. Co-authored-by: James Beilsten-Edmands <30625594+jbeilstenedmands@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug appears to have been introduced in #1647. Since it was only the crystal model, and not the miller indices, that were affected, I don't think it should cause any problems in most cases, although it may affect the resulting unit cells in cases of pseudo-symmetry.
Co-authored-by: James Beilsten-Edmands 30625594+jbeilstenedmands@users.noreply.github.com