Constraints mapping bug #2155
Merged
Constraints mapping bug #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index of the experiment id was being used, not the index of the model. So, if id=5000 is an experiment using the second detector, the previous behaviour tried to apply constraints to the 5001st detector 5001, not the 2nd detector.
Previously, constraint scopes created for parameterisations that were removed due to having too few reflections would cause a crash. Now this elicits a warning and a None constraint, which is later removed from the manager. In addition, the ability to constrain scan-varying parameterisations was removed as this was untested and apparently buggy.
|
I'm confident this bug fix is correct, so merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in which models which are shared by many experiments (such as detector models in serial crystallography) were being identified by
idbeing set to the index in the list of those models, not the index of the experiment list.For a concrete example using data shared by @nksauter this had the effect that that this
.philsnippet:attempted to apply constraints to the 2nd and 5001st detector, not the first and second detectors, picked out by experiments with
id == 1andid == 5000.