Fix histogram output for single datapoint in dials.ssx_index #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2156 +/- ##
==========================================
- Coverage 80.59% 80.58% -0.01%
==========================================
Files 585 585
Lines 66209 66211 +2
Branches 9340 9341 +1
==========================================
- Hits 53359 53355 -4
- Misses 10802 10804 +2
- Partials 2048 2052 +4 |
ndevenish
pushed a commit
that referenced
this pull request
Jul 12, 2022
i.e. if only one crystal is indexed
ndevenish
pushed a commit
that referenced
this pull request
Jul 12, 2022
i.e. if only one crystal is indexed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to create a histogram with one datapoint, numpy can sometimes crash; if it doesn't the output is still not useful as the histogram bin width defaults to 1 which is far too large for this case.