parallelise dials.find_rotation_axis #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2149 Removes the ability to plot at each step of the search, which was anyway not being used by the command line program.
Codecov Report
@@ Coverage Diff @@
## main #2160 +/- ##
==========================================
- Coverage 80.59% 80.58% -0.01%
==========================================
Files 585 585
Lines 66211 66220 +9
Branches 9341 9345 +4
==========================================
+ Hits 53360 53366 +6
- Misses 10802 10803 +1
- Partials 2049 2051 +2 |
dagewa
added a commit
that referenced
this pull request
Sep 21, 2022
ndevenish
pushed a commit
that referenced
this pull request
Oct 31, 2022
* Recover a plot broken by #2160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the test case mentioned in #2149, before:
after (with
nproc=16chosen automatically):