Fix fudged background removal in calibrant #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by Nick Co-authored-by: ndevenish
Codecov Report
@@ Coverage Diff @@
## main #2165 +/- ##
==========================================
- Coverage 80.58% 80.58% -0.01%
==========================================
Files 585 585
Lines 66216 66216
Branches 9342 9342
==========================================
- Hits 53360 53357 -3
- Misses 10805 10806 +1
- Partials 2051 2053 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nick found my scotch-taped background removal for the calibrant overlay. Instead, remove the zeros as Nick found. It also helps to use log type scale to plot intensities.