Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in scaling intensity combination affecting multisweep datasets. #2199

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

jbeilstenedmands
Copy link
Contributor

Affects the Imid midpoint value scoring in the intensity combination for multi sweep datasets only (doesn't affect the scoring of prf and sum).
Issue was repeated multiplication by the correction that was being accumulated in the loop over Imid values.

Fixes #1927

Thanks for @huwjenkins for investigative work here and confirming the fix.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #2199 (0ed2d27) into main (1096557) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0ed2d27 differs from pull request most recent head fe89aed. Consider uploading reports for the commit fe89aed to get more accurate results

@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
- Coverage   80.66%   80.65%   -0.02%     
==========================================
  Files         588      588              
  Lines       66601    66600       -1     
  Branches     9393     9393              
==========================================
- Hits        53721    53713       -8     
- Misses      10802    10806       +4     
- Partials     2078     2081       +3     

@jbeilstenedmands jbeilstenedmands merged commit 5e838f9 into main Aug 10, 2022
@jbeilstenedmands jbeilstenedmands deleted the fix_scaling_intensity_combination branch August 10, 2022 15:38
ndevenish pushed a commit that referenced this pull request Sep 14, 2022
…s. (#2199)

Fix bug in scaling intensity combination affecting Imid midpoint value scoring
for multi sweep datasets.

Fixes #1927

Co-authored-by: Huw Jenkins <huwjenkins@users.noreply.github.com>
ndevenish pushed a commit that referenced this pull request Sep 14, 2022
…s. (#2199)

Fix bug in scaling intensity combination affecting Imid midpoint value scoring
for multi sweep datasets.

Fixes #1927

Co-authored-by: Huw Jenkins <huwjenkins@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in intensity combination in scaling
3 participants