Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reflections #2201

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Remove reflections #2201

merged 5 commits into from
Oct 5, 2022

Conversation

luisodls
Copy link
Contributor

add one more way to run dials.filter_reflections, now by telling remove_by_index=n1,n2,n3...

this is useful if the user wants to remove reflections one by one manually from the GUI

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #2201 (7611000) into main (4925678) will increase coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
+ Coverage   80.65%   81.15%   +0.50%     
==========================================
  Files         588      588              
  Lines       66611    67555     +944     
  Branches     9393     9659     +266     
==========================================
+ Hits        53723    54823    +1100     
+ Misses      10805    10632     -173     
- Partials     2083     2100      +17     

Copy link
Member

@dagewa dagewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luisodls wants this for DUI2 and the feature seems to fit well enough in the existing dials.filter_reflections program. I'll approve now and will merge early next week unless there are further comments.

@ndevenish
Copy link
Member

ndevenish commented Aug 15, 2022

My only real problem is that it's not a generic operation. It's extremely specific, based on the exact structure of the reflection table e.g. only helpful exactly after reading the table in a separate program (which presumably could have then just re-written the table itself). It doesn't fit into any kind of pipeline.

That said, It doesn't affect anything else. I might be happy just putting an extremely high expert level e.g. 6?

@dagewa
Copy link
Member

dagewa commented Sep 7, 2022

@ndevenish I've gone for your pragmatic suggestion. Is this okay now?

@ndevenish ndevenish merged commit c87d280 into main Oct 5, 2022
@ndevenish ndevenish deleted the remove_reflections branch October 5, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants