dials.reciprocal_lattice_viewer: set maximum number of experiment toggles #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the number to 10 by default; can override with max_experiments= on the command line. Fixes #1605
Codecov Report
@@ Coverage Diff @@
## main #2248 +/- ##
==========================================
+ Coverage 80.46% 80.50% +0.03%
==========================================
Files 587 587
Lines 66849 66849
Branches 8883 8883
==========================================
+ Hits 53793 53818 +25
+ Misses 10995 10971 -24
+ Partials 2061 2060 -1 |
|
Chose 15 in retrospect as some standard runs on i19 have 13 and 15 should still be "sane" |
jbeilstenedmands
approved these changes
Oct 18, 2022
|
Request in team chat: please can we instead show a text box with "showing X lattices" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the number to 10 by default; can override with
max_experiments=on the command line, e.g. set to 10000 to restore current behaviour. 10 chosen as "reasonable default"Fixes #1605