-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds option for reduced stills_process logging #2263
Conversation
Awesome, this has been high on my list as well. Big carbon footprint reduction :) I'll review soon, but I'm inclined to make this default, maybe with a couple adjustments to current logging calls to bubble up one or two key items. |
Codecov Report
@@ Coverage Diff @@
## main #2263 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 586 586
Lines 67011 67024 +13
Branches 8924 8926 +2
=======================================
+ Hits 53972 53984 +12
- Misses 10975 10976 +1
Partials 2064 2064 |
Pull it from refinement.reflections.outlier.sauter_poon.verbose
@ndevenish I added handlers for xfel modules so that they could use the logging in dials. Is ok? See cctbx/cctbx_project#819. When that is merged, and with my new commits above, on this branch using @dermen's |
File sizes for the logs from the 6 image SACLA h5 dataset used by test_stills_process:
|
@ndevenish ok to merge? The xfel handler ok? Thanks and no hurry :) |
Any status update here ? |
Some folks are on leave but I think this is fine. Ima hit the auto-merge button. Thanks @dermen. |
Adds options to completely disable logging as well * Use verbosity for SauterPoon outlier rejection. Pull it from refinement.reflections.outlier.sauter_poon.verbose * Add a logging handler for xfel modules * Make suppressed the default Co-authored-by: Aaron Brewster <asbrewster@lbl.gov>
When running jobs in the terminal, this option suppresses a lot of refinement logging, and provides minimal progress feedback to user.