Handle assertion errors in dials.ssx_integrate, arising from bad spotfinding result #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2264 +/- ##
==========================================
+ Coverage 80.50% 80.56% +0.05%
==========================================
Files 587 587
Lines 66849 67097 +248
Branches 8883 8950 +67
==========================================
+ Hits 53819 54054 +235
- Misses 10971 10976 +5
- Partials 2059 2067 +8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some stills datasets, this was found to be an issue for a small fraction of images if background modelling goes bad near the beam stop. Rather than a full fail, catch and report the issue for the given image and continue for the rest.