Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guards for empty tables in reset_ids and renumber_table_id_columns #2281

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

phyy-nx
Copy link
Member

@phyy-nx phyy-nx commented Nov 16, 2022

With tests.

Part of cctbx/cctbx_project#822

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #2281 (30cbc0a) into main (b0f0dc3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2281   +/-   ##
=======================================
  Coverage   80.48%   80.48%           
=======================================
  Files         586      586           
  Lines       66905    66913    +8     
  Branches     8900     8902    +2     
=======================================
+ Hits        53847    53856    +9     
  Misses      10996    10996           
+ Partials     2062     2061    -1     

@phyy-nx phyy-nx merged commit 5431808 into main Nov 17, 2022
@phyy-nx phyy-nx deleted the empty_tables branch November 17, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants