bugfix: counting wrong thing #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2300 +/- ##
==========================================
+ Coverage 80.53% 80.55% +0.01%
==========================================
Files 586 586
Lines 67012 67012
Branches 8924 8924
==========================================
+ Hits 53969 53980 +11
+ Misses 10977 10965 -12
- Partials 2066 2067 +1 |
jbeilstenedmands
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Thanks for spotting and fixing, looks like this was accidentally changed in this PR earlier this year
|
Ok to merge? |
dagewa
pushed a commit
that referenced
this pull request
Feb 20, 2023
This was counting number of clusters instead of size of each cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was counting number of clusters instead of size of each cluster.