Pass fully-resolved path to subprocess.run()
#2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subprocess.Popen docs recommend passing a fully-qualified path to the executable, as resolving the path of the executable is platform dependent. https://docs.python.org/3/library/subprocess.html#subprocess.Popen
rjgildea
added a commit
to conda-forge/dials-feedstock
that referenced
this pull request
Dec 15, 2022
* Updated v3.11.2 * Use dxtbx 3.11 * Pin boost[-cpp]<1.75 * Patch failing Windows test (see cctbx/dxtbx#593) * Add patch for test_symmetry (see dials/dials#2303) * Skip dev.dials.simple_integrate test: Non-obvious test failure on Windows build, doesn't seem worth investigating right now for a non-production piece of code. Co-authored-by: conda-forge-webservices[bot] <91080706+conda-forge-webservices[bot]@users.noreply.github.com> Co-authored-by: Richard Gildea <richard.gildea@diamond.ac.uk>
dagewa
pushed a commit
that referenced
this pull request
Feb 20, 2023
subprocess.Popen docs recommend passing a fully-qualified path to the executable, as resolving the path of the executable is platform dependent. https://docs.python.org/3/library/subprocess.html#subprocess.Popen This was causing test failures in some windows configurations.
dagewa
added a commit
that referenced
this pull request
Mar 2, 2023
rjgildea
pushed a commit
that referenced
this pull request
Mar 3, 2023
Fix another test file for Windows, following #2303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subprocess.Popen()docs recommend passing a fully-qualified path to the executable, as resolving the path of the executable is platform dependent:https://docs.python.org/3/library/subprocess.html#subprocess.Popen