Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using np.float #2309

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Stop using np.float #2309

merged 3 commits into from
Dec 21, 2022

Conversation

dwpaley
Copy link
Contributor

@dwpaley dwpaley commented Dec 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #2309 (c0a838c) into main (e16641d) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2309      +/-   ##
==========================================
- Coverage   80.60%   80.57%   -0.04%     
==========================================
  Files         586      586              
  Lines       67024    67024              
  Branches     8926     8926              
==========================================
- Hits        54024    54002      -22     
- Misses      10935    10959      +24     
+ Partials     2065     2063       -2     

Copy link
Contributor

@jbeilstenedmands jbeilstenedmands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dwpaley dwpaley enabled auto-merge (squash) December 21, 2022 18:36
@dwpaley dwpaley merged commit 6105ab0 into main Dec 21, 2022
@dwpaley dwpaley deleted the remove_np_float branch December 21, 2022 19:27
rjgildea pushed a commit that referenced this pull request Jan 13, 2023
np.float has been a deprecated alias for float and is removed as of v1.24:
https://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations
dagewa pushed a commit that referenced this pull request Feb 20, 2023
np.float has been a deprecated alias for float and is removed as of v1.24:
https://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants