Fix masking failure case when direct beam is exactly in the centre of a pixel #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failure case by shifting the s1 calculation to the edge of the pixel instead. Fixes #2322
Codecov Report
@@ Coverage Diff @@
## main #2329 +/- ##
=======================================
Coverage 80.72% 80.73%
=======================================
Files 589 589
Lines 68175 68192 +17
Branches 9145 9146 +1
=======================================
+ Hits 55035 55054 +19
+ Misses 11032 11028 -4
- Partials 2108 2110 +2 |
|
@huwjenkins just wondering if this fix works for you? |
|
Yep fix works for me. Thanks! |
…when-beam-centre-is-05-integral-pixel-values
…when-beam-centre-is-05-integral-pixel-values
…when-beam-centre-is-05-integral-pixel-values
dagewa
deleted the
2322-traceback-from-resolutionmaskgenerator-when-beam-centre-is-05-integral-pixel-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In that case, take the pixel position from the edge of the pixel rather than the centre.