Use dials-data instead of dials_regression/refinement_test_data
#2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix filenames for test_constraints
…s a deprecated DataBlock!
I don't understand why this error occurs, because the files on dials-data are identical copies of those on dials_regression in this case. Nevertheless, it is reasonable to raise the tolerance, which is still at the level of 10 nm difference in detector distance.
warning failure. Also note that the change should be temporary and revisited later in the year.
Codecov Report
@@ Coverage Diff @@
## main #2343 +/- ##
==========================================
+ Coverage 80.72% 83.11% +2.38%
==========================================
Files 589 593 +4
Lines 68175 68579 +404
Branches 9145 9210 +65
==========================================
+ Hits 55036 57001 +1965
+ Misses 11031 9447 -1584
- Partials 2108 2131 +23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests that previously used files in
dials_regression/refinement_test_datanow use copies of those files accessed by the public dials-data package.