Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report suggested resolution limit in dials.merge #2351

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

jbeilstenedmands
Copy link
Contributor

Report a suggested limit based on a fit to cc1/2=0.3, as in scaling.

Makes the output of merging stats in dials.merge consistent with dials.scale.

Useful to report the fit in merging for the dose series case, where you don't necesarily scale this subset of data individually before merging.

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #2351 (503bfdb) into main (621c781) will increase coverage by 2.38%.
The diff coverage is 92.39%.

❗ Current head 503bfdb differs from pull request most recent head 90a6a4a. Consider uploading reports for the commit 90a6a4a to get more accurate results

@@            Coverage Diff             @@
##             main    #2351      +/-   ##
==========================================
+ Coverage   80.72%   83.11%   +2.38%     
==========================================
  Files         589      593       +4     
  Lines       68175    68564     +389     
  Branches     9145     9217      +72     
==========================================
+ Hits        55036    56986    +1950     
+ Misses      11031     9445    -1586     
- Partials     2108     2133      +25     

@jbeilstenedmands jbeilstenedmands merged commit ded94c5 into main Mar 2, 2023
@jbeilstenedmands jbeilstenedmands deleted the report_resolution_limit_in_merge branch March 2, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants