Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 3 macrocycles of refinement by default in dials.ssx_integrate #2352

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

jbeilstenedmands
Copy link
Contributor

At least a couple more macrocycles should be the default, so that the improved predictions from the first round of refinement can be used when calculating the reflection properties for subsequent refinement.

This makes the program have a higher runtime, but I have some WIP performance improvements that more than compensate.

newsfragments/2352.misc Outdated Show resolved Hide resolved
Co-authored-by: Richard Gildea <rjgildea@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #2352 (41cb27b) into main (e063d4a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 41cb27b differs from pull request most recent head 62aee42. Consider uploading reports for the commit 62aee42 to get more accurate results

@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
- Coverage   83.11%   83.10%   -0.01%     
==========================================
  Files         593      593              
  Lines       68542    68542              
  Branches     9213     9213              
==========================================
- Hits        56967    56962       -5     
- Misses       9447     9449       +2     
- Partials     2128     2131       +3     

@jbeilstenedmands jbeilstenedmands enabled auto-merge (squash) February 28, 2023 12:19
@jbeilstenedmands jbeilstenedmands merged commit 7537392 into main Feb 28, 2023
@jbeilstenedmands jbeilstenedmands deleted the ssx_integrate_3_macro branch February 28, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants