dials.export_bitmaps with resolution rings

[dagewa]

This adds optional resolution rings to dials.export_bitmaps. Additional PHIL controls are:

show_resolution_rings = False
  .type = bool
resolution_rings {
  number = 5
    .type = int(value_min=1)
  fontsize = 30
    .type = int
}

Example with a P6M image:

dials.export_bitmaps grid_full_cbf_0005.cbf show_resolution_rings=True

This also works for multi-panel and non-coplanar detectors. For I23:

dials.export_bitmaps germ_13KeV_0001.cbf show_resolution_rings=True resolution_rings.number=10

[dagewa]

I see there are some artefacts at the image edges for the single panel case

[Baharis]

This might be more of an esthetic choice than anything, but what would you say about putting all phil parameters in one scope, i.e.:

resolution_rings {
  show = False
    .type = bool
  number = 5
    .type = int(value_min=1)
  fontsize = 30
    .type = int
}

[dagewa]

Yeah, I'm inclined to agree that's better 👍

[dagewa]

Ah, I know why I did that. It's because dials.image_viewer has the parameter show_resolution_rings so I was going for consistency. But hardly anyone uses the PHIL parameters for dials.image_viewer, so that's not a very strong reason.

[Baharis]

Ah, consistency is definitely also a great reason. I personally don't have particular interest in any version; I was just curious.

[codecov]

Codecov Report

Merging #2360 (f93ef98) into main (cfe100e) will decrease coverage by 4.39%.
The diff coverage is 80.67%.

❗ Current head f93ef98 differs from pull request most recent head 49abaa0. Consider uploading reports for the commit 49abaa0 to get more accurate results

@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
- Coverage   82.90%   78.51%   -4.39%     
==========================================
  Files         593      602       +9     
  Lines       68592    73173    +4581     
  Branches     9221     9935     +714     
==========================================
+ Hits        56863    57454     +591     
- Misses       9613    13599    +3986     
- Partials     2116     2120       +4