-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-panel and multi-experiment dials.rs_mapper
#2362
Conversation
I think this restriction is artificial. Whether or not a multi- experiment calculation is meaningful depends on context, but we can leave that up to the user to decide.
dials.rs_mapper
dials.rs_mapper
In addition, I removed the restriction to operate over one experiment only. There may be situations like multi sweep datasets where constructing the reciprocal lattice over all sweeps is interesting. |
Codecov Report
@@ Coverage Diff @@
## main #2362 +/- ##
==========================================
- Coverage 82.83% 82.82% -0.02%
==========================================
Files 593 593
Lines 68601 68612 +11
Branches 9222 9221 -1
==========================================
Hits 56828 56828
- Misses 9656 9668 +12
+ Partials 2117 2116 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for enhancement. The changes look OK to me.
How about adding an option to rotate the experiment according to the orientation matrix, when given (Just an idea for future enhancement, not a requirement for this pull request.) |
Thanks, that sounds useful. In fact, perhaps that should be default if multiple experiments are provided that have crystal models. I might still put it in here - I can't merge this yet because we're getting failures with I23 data and it isn't clear why. |
…xy had been calculated incorrectly
AFAICT there was not one on dials-data, so I used an I23 image from dials_regression, which is already used in other tests.
Allow
dials.rs_mapper
to work for multi-panel detectors by looping over panels at the highest level and accumulating the results. So far I tested only for a very simple 4 panel, small molecule MicroED dataset and the results appear sensible.This should close #2333.