Increase robustness of constrained refinement test #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constraining the "Dist" parameter only ensures a constrained distance when the Tau2, Tau3 (tilt and twist) parameters are fixed. With that, the tolerance can be tightened again.
|
A further, more fundamental, fix is to fix the |
Codecov Report
@@ Coverage Diff @@
## main #2367 +/- ##
=======================================
Coverage 82.83% 82.84%
=======================================
Files 593 593
Lines 68602 68601 -1
Branches 9222 9222
=======================================
+ Hits 56827 56830 +3
+ Misses 9657 9654 -3
+ Partials 2118 2117 -1 |
dagewa
added a commit
that referenced
this pull request
Mar 13, 2023
* Switch off outlier rejection to try to make a test more deterministic * Constraining the "Dist" parameter only ensures a constrained distance when the Tau2, Tau3 (tilt and twist) parameters are fixed. With that, the tolerance can be tightened again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test occasionally fails in the CI. The tolerance was increased in #2343, but there are still some failures in PR test runs. This change switches off outlier rejection (which is irrelevant for what is being tested) in a further effort to ensure the test is deterministic.