Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the experiment identifiers map when slicing a reflection table. #2371

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Keep the experiment identifiers map when slicing a reflection table. #2371

merged 2 commits into from
Mar 16, 2023

Conversation

jbeilstenedmands
Copy link
Contributor

Fixes #2276

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #2371 (57bdcc6) into main (6f8cd58) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 57bdcc6 differs from pull request most recent head cfa514e. Consider uploading reports for the commit cfa514e to get more accurate results

@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
+ Coverage   78.47%   78.51%   +0.03%     
==========================================
  Files         602      602              
  Lines       73184    73193       +9     
  Branches     9934     9935       +1     
==========================================
+ Hits        57433    57467      +34     
+ Misses      13633    13608      -25     
  Partials     2118     2118

phyy-nx
phyy-nx approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@phyy-nx phyy-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jbeilstenedmands jbeilstenedmands merged commit f2aaec4 into main Mar 16, 2023
@jbeilstenedmands jbeilstenedmands deleted the fix_slice_table_2276 branch March 16, 2023 16:20
phyy-nx added a commit to cctbx/cctbx_project that referenced this pull request Mar 27, 2023
@phyy-nx
Remove reflection_table_utils::slice_table
0003fb9 
Unneeded now that dials/dials#2371 is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phyy-nx phyy-nx phyy-nx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slicing a reflection table drops the identifier map
3 participants
@jbeilstenedmands @phyy-nx @DiamondLightSource-build-server