Call .astype(int) on .as_numpy_array() result
#2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, on Windows, the underlying dtype.type is np.intc rather than np.int32 or np.int64, which results in an error when calling pd.merge
Codecov Report
@@ Coverage Diff @@
## main #2383 +/- ##
==========================================
- Coverage 78.53% 78.50% -0.04%
==========================================
Files 602 602
Lines 73372 73373 +1
Branches 9964 9964
==========================================
- Hits 57622 57599 -23
- Misses 13626 13650 +24
Partials 2124 2124 |
This reverts commit a6eaca1. flumpy.to_numpy(<flex_int>) generates an array with dtype=np.intc on Windows
|
dcd34b1 is identical to the current codestate and passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, on Windows, the underlying
dtype.typeisnp.intcrather thannp.int32ornp.int64, which results in an error when callingpd.mergeas the typenp.intcis missing from the following lookup table in pandas 2.0.0:https://github.com/pandas-dev/pandas/blob/3ce07cb46986ce59427b601c6878c81633e436eb/pandas/core/reshape/merge.py#L108-L124
Fixes #2382