Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dials.export_bitmaps: scale resolution rings according to binning #2392

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

rjgildea
Copy link
Contributor

Fixes #2391

Using dials.export_bitmaps $(dials.data get -q x4wide)/*0001.cbf resolution_rings.show=True with binning=1:
b1-0001
binning=2:
b2-0001
binning=4:
b4-0001
binning=8:
b8-0001

@rjgildea rjgildea requested a review from dagewa April 19, 2023 11:11
Copy link
Member

@dagewa dagewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Glad it turned out to be reasonably simple :)

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #2392 (9085e05) into main (18146d1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 9085e05 differs from pull request most recent head 0f7f2da. Consider uploading reports for the commit 0f7f2da to get more accurate results

@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
- Coverage   78.62%   78.60%   -0.02%     
==========================================
  Files         603      603              
  Lines       73626    73627       +1     
  Branches    10002    10002              
==========================================
- Hits        57885    57878       -7     
- Misses      13611    13617       +6     
- Partials     2130     2132       +2     

@rjgildea rjgildea merged commit 58864f6 into main Apr 19, 2023
16 checks passed
@rjgildea rjgildea deleted the export-bitmaps-resolution-rings-binning branch April 19, 2023 13:55
toastisme pushed a commit to toastisme/dials that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dials.export_bitmaps: new resolution rings display incorrect for binning != 1
4 participants