Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off parameter auto-reduction for refinement special cases #2431

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Jun 7, 2023

As discussed in #2430, allow a workaround to avoid this procedure via a parameter with high expert level

Need to set the PHIL type, otherwise the default False is interpreted
as a list of string: ['False'] and is truthy...
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #2431 (3461dd7) into main (8ff14c8) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2431      +/-   ##
==========================================
- Coverage   78.68%   78.65%   -0.03%     
==========================================
  Files         606      606              
  Lines       73976    73996      +20     
  Branches    10064    10065       +1     
==========================================
- Hits        58208    58205       -3     
- Misses      13630    13651      +21     
- Partials     2138     2140       +2     

@ndevenish ndevenish enabled auto-merge (squash) June 12, 2023 13:29
@ndevenish ndevenish disabled auto-merge June 12, 2023 13:30
@ndevenish ndevenish merged commit 04e5396 into main Jun 12, 2023
13 of 14 checks passed
@ndevenish ndevenish deleted the 2430-dialsrefine-being-able-to-turn-off-auto_reduce-would-be-useful-in-certain-cases branch June 12, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dials.refine being able to turn off auto_reduce would be useful in certain cases
3 participants