Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print template for every image of a grid scan #2432

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Conversation

rjgildea
Copy link
Contributor

Fixes #2413

With main:

$ dials.import $DIALS_DATA/thaumatin_grid_scan/thau_3_2_00*
DIALS (2018) Acta Cryst. D74, 85-97. https://doi.org/10.1107/S2059798317017235
DIALS 3.dev.968-g8ff14c84f-release
The following parameters have been modified:

input {
  experiments = <image files>
}

--------------------------------------------------------------------------------
  format: <class 'dxtbx.format.FormatCBFMiniPilatusDLS6MSN119.FormatCBFMiniPilatusDLS6MSN119'>
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:6:6
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:11:11
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:13:13
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:9:9
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:17:17
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:10:10
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:14:14
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:18:18
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:15:15
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:7:7
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:1:1
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:8:8
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:19:19
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:4:4
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:3:3
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:12:12
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:16:16
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:5:5
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:2:2
  num images: 19
  sequences:
    still:    1
    sweep:    0
  num stills: 0
--------------------------------------------------------------------------------
Writing experiments to imported.expt

With this PR:

$ dials.import $DIALS_DATA/thaumatin_grid_scan/thau_3_2_00*
DIALS (2018) Acta Cryst. D74, 85-97. https://doi.org/10.1107/S2059798317017235
DIALS 3.dev.987-g53d2cf7f2
The following parameters have been modified:

input {
  experiments = <image files>
}

--------------------------------------------------------------------------------
  format: <class 'dxtbx.format.FormatCBFMiniPilatusDLS6MSN119.FormatCBFMiniPilatusDLS6MSN119'>
  template: /dls/science/groups/scisoft/DIALS/dials_data/thaumatin_grid_scan/thau_3_2_####.cbf.bz2:1:19
  num images: 19
  sequences:
    still:    1
    sweep:    0
  num stills: 0
--------------------------------------------------------------------------------
Writing experiments to imported.expt

Copy link
Contributor

@graeme-winter graeme-winter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change set looks good, very minor typographical observation, well played Walrus sir.

newsfragments/2432.bugfix Outdated Show resolved Hide resolved
src/dials/command_line/dials_import.py Show resolved Hide resolved
src/dials/command_line/dials_import.py Show resolved Hide resolved
@ndevenish ndevenish merged commit 2f915cb into main Jun 12, 2023
5 of 12 checks passed
@ndevenish ndevenish deleted the quieter-template branch June 12, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dials.import excessive output
4 participants