Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of procrunner with subprocess #2433

Merged
merged 83 commits into from
Jun 15, 2023
Merged

Replace use of procrunner with subprocess #2433

merged 83 commits into from
Jun 15, 2023

Conversation

rjgildea
Copy link
Contributor

Change some use of tmpdir fixture to tmp_path while passing by.

@rjgildea
dev.dials.generate_tutorial_text: procrunner -> subprocess
f3029c1
@rjgildea
dev.dials.make_sphinx_html: procrunner -> subprocess
a2176ae
@rjgildea
test_cpp_components: procrunner -> subprocess
4a63d4c
@rjgildea
test_plot_reflections: procrunner -> subprocess
6f62dff
@rjgildea
test_scan_varying_integration_bug: procrunner -> subprocess
a2010fa
@rjgildea
test_gmodel: procrunner -> subprocess
709c247
@rjgildea
test_index: procrunner -> subprocess
c8c0c4e
@rjgildea
test_kapton: procrunner -> subprocess
c1c8ce3
@rjgildea
test_simple_integrate: procrunner -> subprocess
d3465e4
@rjgildea
test_constraints: procrunner -> subprocess
c0f5ce5
@rjgildea
test_cspad_refinement: procrunner -> subprocess
20eef54
@rjgildea
test_refine_multi_stills: procrunner -> subprocess
2587702
@rjgildea
Use capture_output=True since we usually test for absence of stderr
67b97d3
@rjgildea
test_scan_varying_beam_refinement: procrunner -> subprocess
97e8262
@rjgildea
test_refine_multi_wedges: procrunner -> subprocess
828e411
@rjgildea
test_sv_multi_panel_refinement: procrunner -> subprocess
39a62ba
@rjgildea
test_xfel_metrology: procrunner -> subprocess
9087f01
@rjgildea
test_scale: procrunner -> subprocess
c628461
@rjgildea
test_align_crystal: procrunner -> subprocess
fb376d7
@rjgildea
test_apply_mask: procrunner -> subprocess
b88008e
@rjgildea
test_assign_experiment_identifiers: procrunner -> subprocess
37dad2b
@rjgildea
test_background: procrunner -> subprocess
208a6a7
@rjgildea
test_check_indexing_symmetry: procrunner -> subprocess
6b7b58c
@rjgildea
test_cluster_unit_cell: procrunner -> subprocess
4f34ff0
@rjgildea
test_combine_experiments: procrunner -> subprocess
33bd392
@rjgildea
test_compute_delta_cchalf: procrunner -> subprocess
564799d
@rjgildea
test_convert_to_cbf: procrunner -> subprocess
862279b
@rjgildea
test_create_profile_model: procrunner -> subprocess
6faf154
@rjgildea
test_damage_analysis: procrunner -> subprocess
480aa3e
@rjgildea
test_detect_blanks: procrunner -> subprocess
3c364dd
@rjgildea
test_report: procrunner -> subprocess
2ab3f31
@rjgildea
Call dials_data with pathlib=True
30cbdaa
@rjgildea
Missing shutil.which
aec70dc
@rjgildea
test_rl_png: procrunner -> subprocess
cff5a98
@rjgildea
test_rs_mapper: procrunner -> subprocess
d5ca0d4
@rjgildea
test_sequence_to_stills: procrunner -> subprocess
a19146c 
tmpdir -> tmp_path
@rjgildea
test_show: procrunner -> subprocess
f9a4e48 
tmpdir -> tmp_path
@rjgildea
test_slice_sequence: procrunner -> subprocess
e1521d8
@rjgildea
test_sort_reflections: procrunner -> subprocess
f06bc94
@rjgildea
test_split_experiments: procrunner -> subprocess
4bf00f9
@rjgildea
test_spot_counts_per_image: procrunner -> subprocess
d1776a7
@rjgildea
test_ssx_index: procrunner -> subprocess
dfd58dd
@rjgildea
test_ssx_integrate: procrunner -> subprocess
d784257
@rjgildea
test_ssx_reduction: procrunner -> subprocess
fb016ea
@rjgildea
test_stereographic_projections: procrunner -> subprocess
5636e7a
@rjgildea
test_stills_process: procrunner -> subprocess
4d125fd
@rjgildea
test_symmetry: procrunner -> subprocess
9c43bd2
@rjgildea
test_two_theta_refine: procrunner -> subprocess
4f54ec5
@rjgildea
test_masking: procrunner -> subprocess
a6fa365
@rjgildea
Remove procrunner dependency
2e2ed0d
@rjgildea rjgildea requested a review from ndevenish June 14, 2023 14:54
@rjgildea rjgildea marked this pull request as ready for review June 14, 2023 14:54
@rjgildea rjgildea changed the title WIP: replace use of procrunner with subprocess Replace use of procrunner with subprocess Jun 14, 2023
@rjgildea rjgildea merged commit 937fe91 into main Jun 15, 2023
16 checks passed
@rjgildea rjgildea deleted the procrunner-begone branch June 15, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndevenish ndevenish Awaiting requested review from ndevenish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjgildea @DiamondLightSource-build-server