Fix import template tests on windows #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call dials_data with pathlib=True to avoid warning
rjgildea
added a commit
to regro-cf-autotick-bot/dials-feedstock
that referenced
this pull request
Jun 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #2437 +/- ##
==========================================
- Coverage 78.69% 78.66% -0.04%
==========================================
Files 606 606
Lines 74017 74017
Branches 10066 10066
==========================================
- Hits 58249 58224 -25
- Misses 13630 13654 +24
- Partials 2138 2139 +1 |
rjgildea
added a commit
to conda-forge/dials-feedstock
that referenced
this pull request
Jun 15, 2023
* updated v3.15.0 * Remove patches that should no longer be needed * Require dxtbx==3.15 * Patch failing import test See dials/dials#2437 * Fix path to patch * Patching of test xfel dependency is still required See dials#2389 and dials#2404 * Remove newsfragment cruft from patches --------- Co-authored-by: Richard Gildea <richard.gildea@diamond.ac.uk>
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
dials_datawithpathlib=Trueto avoid warning