Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless checkbox #2458

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Jul 10, 2023

A 5 minute fix for #712 (after 4 and a half years)

@dagewa dagewa linked an issue Jul 10, 2023 that may be closed by this pull request
@dagewa
Copy link
Member Author

dagewa commented Jul 14, 2023

I think the macos test failure has nothing to do with this PR

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #2458 (de3a568) into main (4ea64e8) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head de3a568 differs from pull request most recent head 7ff928b. Consider uploading reports for the commit 7ff928b to get more accurate results

@@           Coverage Diff           @@
##             main    #2458   +/-   ##
=======================================
  Coverage   78.68%   78.69%           
=======================================
  Files         606      606           
  Lines       74150    74145    -5     
  Branches    10087    10087           
=======================================
+ Hits        58347    58350    +3     
+ Misses      13660    13653    -7     
+ Partials     2143     2142    -1     

@dagewa dagewa merged commit 8d0e713 into main Jul 20, 2023
16 checks passed
@dagewa dagewa deleted the 712-show-mask-in-dialsimage_viewer-is-confusing branch July 20, 2023 16:23
dagewa added a commit that referenced this pull request Jul 21, 2023
Removed useless "Show mask" button from the Mask tool in dials.image_viewer

Fixes #712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show mask in dials.image_viewer is confusing
2 participants