No datablocks

[dagewa]

Two tests for dials.search_beam_position are changed to no longer use datablock.json files. After merging this and cctbx/dxtbx#570, there should be no test failures.

[codecov]

Codecov Report

Merging #2465 (82f84db) into main (96ddc58) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head 82f84db differs from pull request most recent head 4ab6e34. Consider uploading reports for the commit 4ab6e34 to get more accurate results

@@            Coverage Diff             @@
##             main    #2465      +/-   ##
==========================================
+ Coverage   78.66%   78.80%   +0.14%     
==========================================
  Files         608      608              
  Lines       74528    74516      -12     
  Branches    10141    10140       -1     
==========================================
+ Hits        58628    58725      +97     
+ Misses      13727    13618     -109     
  Partials     2173     2173              

[graeme-winter]

Change set looks good, and as a happy side-effect also removes references to more pickle as well. Thanks you. Some questions inline for my own enlightenment.

[ndevenish]

This looks ready. Will merge after release.

[ndevenish]

Couple of remaining usages of datablock in xfail tests added by #1910 - test_phi_scan.py and test_index.py

These are probably fixed by dials/data#312, which we can probably do now.

[ndevenish]

Oh, and https://github.com/dials/dials/blob/main/doc/sphinx/documentation/tutorials/3DED/lysozyme_nanocrystals.rst mentions datablocks a whole bunch, how do we feel about that tutorial?

[dagewa]

It's kind of frozen in time, that one. It mentions specific versions of DIALS and CCP4 at the start. IIRC it was kept around following a reviewer request that the instructions for processing those datasets be made public. However, it is now quite hard to find a version of DIALS for which those instructions actually work. Nevertheless, it was already de-linked from the tutorial index page, so people are unlikely to stumble across it.