Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam model probe changes in dials.show tests. #2482

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Aug 2, 2023

This is the DIALS companion to cctbx/dxtbx#647, to fix test_show.py for new output lines.

@dagewa
Copy link
Member Author

dagewa commented Aug 2, 2023

NB I have tested xia2 as well this time and a third PR over there is not necessary

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2482 (370150a) into main (4b86bb6) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 370150a differs from pull request most recent head 51fab87. Consider uploading reports for the commit 51fab87 to get more accurate results

@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
- Coverage   78.61%   78.55%   -0.06%     
==========================================
  Files         607      607              
  Lines       74440    74440              
  Branches    10134    10134              
==========================================
- Hits        58518    58475      -43     
- Misses      13759    13806      +47     
+ Partials     2163     2159       -4     

@ndevenish ndevenish enabled auto-merge (squash) August 4, 2023 15:50
@ndevenish ndevenish merged commit 93c1364 into main Aug 4, 2023
15 of 16 checks passed
@ndevenish ndevenish deleted the dials-show-beam-model-probe-changes branch August 4, 2023 17:57
toastisme pushed a commit to toastisme/dials that referenced this pull request Aug 21, 2023
Beam models now include Probe details on the type of beam.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants