dials.rlv
- handle cases where the beam centre cannot be set
#2483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a beam centre could not be calculated,
dials.reciprocal_lattice_viewer
would raise errors and may even distort the lattice (see #2481). The distortion was occurring because the beam centre controls defaulted to 0.0, 0.0. In some situations when setting the beam centre failed, the beam centre was then read from the control values and therefore set to 0.0, 0.0.This PR works around by disabling the controls in situations when the beam centre cannot be set. Then, if the control is disabled, its value will not be passed back when updating the models.