Fix exclude_images_multiple for trimmed scans
#2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The excluded image numbers should always be a multiple of the `exclude_images_multiple` parameter, no matter what the start image of the scan is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2511, it turns out that sometimes
dials.refinetrims the scan so that it no longer starts at image number 1. In such cases, the excluded images should always be multiples of theexclude_images_multipleparameter, whatever the first image number is. This change ensures that. Also, this allows the parameter to work correctly if the first few images were excluded earlier, such as duringdials.import.