Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dials.sequence_to_stills improvements #2517

Merged
merged 6 commits into from
Oct 15, 2023
Merged

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Oct 12, 2023

Ensure that dials.sequence_to_stills:

  • Generates experiment identifiers
  • Works with scan-static models
  • Provides some basic logging

@dagewa dagewa requested a review from phyy-nx October 12, 2023 14:49
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #2517 (5a130fc) into main (ba4a34b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 5a130fc differs from pull request most recent head ea578dc. Consider uploading reports for the commit ea578dc to get more accurate results

@@            Coverage Diff             @@
##             main    #2517      +/-   ##
==========================================
+ Coverage   78.82%   78.84%   +0.01%     
==========================================
  Files         609      609              
  Lines       74562    74589      +27     
  Branches    10605    10606       +1     
==========================================
+ Hits        58775    58807      +32     
+ Misses      13612    13611       -1     
+ Partials     2175     2171       -4     

@dagewa dagewa merged commit a47e087 into main Oct 15, 2023
18 checks passed
@dagewa dagewa deleted the sequence_to_stills_improvements branch October 15, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants