Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_datasets as an alias for use_datasets in dials.scale #2525

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

jbeilstenedmands
Copy link
Contributor

Fixes #2388

@jbeilstenedmands jbeilstenedmands enabled auto-merge (squash) October 18, 2023 09:13
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2525 (ec8cee0) into main (490f4f7) will increase coverage by 11.89%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head ec8cee0 differs from pull request most recent head f34a5e8. Consider uploading reports for the commit f34a5e8 to get more accurate results

@@             Coverage Diff             @@
##             main    #2525       +/-   ##
===========================================
+ Coverage   78.79%   90.68%   +11.89%     
===========================================
  Files         609      282      -327     
  Lines       74609    25617    -48992     
  Branches    10608     2288     -8320     
===========================================
- Hits        58790    23232    -35558     
+ Misses      13644     2278    -11366     
+ Partials     2175      107     -2068     

@jbeilstenedmands jbeilstenedmands merged commit ca52cf0 into main Oct 18, 2023
14 of 18 checks passed
@jbeilstenedmands jbeilstenedmands deleted the include_datasets_option_in_scale branch October 18, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include_images for dials scale
2 participants