Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle shared models in dials.index with known orientations #2534

Merged

Conversation

jbeilstenedmands
Copy link
Contributor

Fixes #1819

@jbeilstenedmands
Copy link
Contributor Author

Just to demonstrate the output on some of the l-cysteine test data:
Command
xia2 image=/Users/whi10850/dials/build/dials_data/l_cysteine_dials_output/l-cyst_01_00001.cbf:1:15 image=/Users/whi10850/dials/build/dials_data/l_cysteine_dials_output/l-cyst_02_00001.cbf:1:15 min_spots.per_degree=10 xtriage_analysis=False multi_sweep_indexing=True
Followed by
dials.index 9_indexed.{expt,refl}
This PR:

+------------+-------------+---------------+-------------+
|   Imageset |   # indexed |   # unindexed | % indexed   |
|------------+-------------+---------------+-------------|
|          0 |          42 |             7 | 85.7%       |
|          1 |          30 |             3 | 90.9%       |
+------------+-------------+---------------+-------------+

dials-main:

+------------+-------------+---------------+-------------+
|   Imageset |   # indexed |   # unindexed | % indexed   |
|------------+-------------+---------------+-------------|
|          0 |          42 |             7 | 85.7%       |
|          1 |           0 |            33 | 0.0%        |
+------------+-------------+---------------+-------------+

@jbeilstenedmands jbeilstenedmands merged commit a77bd2e into dials:main Oct 25, 2023
9 of 11 checks passed
@jbeilstenedmands jbeilstenedmands deleted the reindex_known_orientations_fix branch October 25, 2023 08:49
dagewa pushed a commit that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dials.index re-indexing multi-sweep data only re-indexes 1st sweep
2 participants