Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix program docs PHIL string for dials.refine #2551

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Fix program docs PHIL string for dials.refine #2551

merged 3 commits into from
Nov 7, 2023

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Nov 7, 2023

dials.refine sets some overrides, so we need to point to the final PHIL scope here. Tested with dev.dials.make_sphinx_html. Fixes #2542

dagewa and others added 3 commits November 7, 2023 12:22
dials.refine overrides a couple of PHIL parameters, so make sure
we take the final PHIL scope used by the program.
Fixes #2542
@dagewa dagewa merged commit b375f18 into main Nov 7, 2023
4 of 6 checks passed
@dagewa dagewa deleted the fix-refine-docs branch November 7, 2023 14:23
dagewa added a commit that referenced this pull request Nov 30, 2023
* Fix dials.refine program documentation.

dials.refine overrides a couple of PHIL parameters, so make sure
we take the final PHIL scope used by the program.

* News

Fixes #2542
dagewa added a commit that referenced this pull request Nov 30, 2023
* Fix dials.refine program documentation.

dials.refine overrides a couple of PHIL parameters, so make sure
we take the final PHIL scope used by the program.

* News

Fixes #2542
graeme-winter pushed a commit to graeme-winter/dials that referenced this pull request Nov 30, 2023
* Fix dials.refine program documentation.

dials.refine overrides a couple of PHIL parameters, so make sure
we take the final PHIL scope used by the program.

* News

Fixes dials#2542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Online documentation out of date re: default for scan_varying refinement
2 participants