Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dials.sequence_to_stills: skip images with no reflections #2554

Merged

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Nov 14, 2023

Spotted during small molecule SerialED processing with @jbeilstenedmands: if an image does not have any reflections on it then we do not want to include that stills experiment in the output. Otherwise, dials.ssx_integrate will fail with:

Attempting to split multi-still reflection table
Sorry: Unequal number of reflection tables and experiments after splitting

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2554 (b8006b5) into main (3cf885b) will decrease coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is 93.58%.

❗ Current head b8006b5 differs from pull request most recent head 7035e2e. Consider uploading reports for the commit 7035e2e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2554      +/-   ##
==========================================
- Coverage   78.84%   78.82%   -0.03%     
==========================================
  Files         609      609              
  Lines       74659    74729      +70     
  Branches    10623    10637      +14     
==========================================
+ Hits        58868    58908      +40     
- Misses      13617    13644      +27     
- Partials     2174     2177       +3     

@jbeilstenedmands jbeilstenedmands merged commit 7d2fb29 into main Nov 22, 2023
18 checks passed
@jbeilstenedmands jbeilstenedmands deleted the sequence_to_stills-skip-images-with-no-reflections branch November 22, 2023 11:20
graeme-winter pushed a commit to graeme-winter/dials that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants