image_viewer open in background by default?

[ndevenish]

Is there any compelling reason not to do this?

Raised by @jbeilstenedmands

[graeme-winter]

i.e. when you type dials.image_viewer it releases the terminal? Or we put in the tutorials

dials.image_viewer <stuff> &

I understand why this was raised, the terminal being busy is a frequently raised workshop problem

[jbeilstenedmands]

Yes I raised this as we often see people stumbling on this in tutorials. In my opinion I think it would be better if this happened automatically, rather than having to explain another linux feature to new learners.

[ndevenish]

i.e. when you type dials.image_viewer it releases the terminal?

Yes, explicitly this. I don't think the output is ever really useful except for crashes, which we can probably pass through if it happens on launch.

[dagewa]

Agree. See also dials.rlv

[dagewa]

How do we actually do this though? Adding & to the relevant lines in the dials.image_viewer dispatcher certainly works:

  exec "$LIBTBX_PYEXE" "$LIBTBX_BUILD/../modules/dials/src/dials/command_line/image_viewer.py" &

and

  exec "$LIBTBX_PYEXE" "$LIBTBX_BUILD/../modules/dials/src/dials/command_line/image_viewer.py" "$@" &

but this file is auto-generated