-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print helpful error message in dials.slice_sequence in case of invalid input. #2570
Conversation
…d input. Also allow multi-expt files for exclude_images_multiple
In an example case, it now prints:
I also found the traceback could be triggered in the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy that this avoids the user seeing a traceback and the error message provided is informative 👍
Co-authored-by: David Waterman <dagewa@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2570 +/- ##
=======================================
Coverage 78.53% 78.54%
=======================================
Files 609 609
Lines 75054 75057 +3
Branches 10712 10713 +1
=======================================
+ Hits 58945 58951 +6
+ Misses 13943 13939 -4
- Partials 2166 2167 +1 |
Also allow multi-expt files for exclude_images_multiple
FIxes #2098