dials.reciprocal_lattice_viewer: correctly record beam centre panel for multi-panel detectors #2572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When models are loaded, the beam centre is calculated, and if this is succesful, the result is written back to the beam centre controls in the GUI. Unfortunately, the panel number was not written back to its control, which defaulted to
0
. This meant that whenever the relp positions were next calculated, it would do so under the assumption of the beam centre being in panel0
. This is the cause of the errors reported with data from I23 (#2571).This PR correctly updates the control when models are loaded, so that the geometry is correct when next recalculated.