dials.export_bitmaps fix for a single cbf image with imageset_index parameter. #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhwilliams
pushed a commit
that referenced
this pull request
Feb 27, 2024
benjaminhwilliams
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps a slightly unusual use case, but one that we use at Diamond.
The usage
dials.export_bitmaps image_0900.cbf imageset_index=1used to work prior to #2417 (but was untested). This PR restores that functionality, i.e. when callingdials.export_bitmapson a set of images or an experiment list where the images don't start from number one, the imageset index refers to the actual set of images in the experiment, rather than the scan range numbers (which would be 900 in this case).