dials.refine: better error message on failure with a zero length reflection list
#2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get a confusing error, like: Experiment id 0 contains no reflections with valid scan angles and while this is strictly true, the real cause of failure is that there are no reflections at all. Catch that separately.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2607 +/- ##
===========================================
+ Coverage 78.52% 90.67% +12.15%
===========================================
Files 609 282 -327
Lines 75094 25727 -49367
Branches 10722 2294 -8428
===========================================
- Hits 58968 23329 -35639
+ Misses 13954 2291 -11663
+ Partials 2172 107 -2065 |
benjaminhwilliams
pushed a commit
that referenced
this pull request
Feb 27, 2024
…flection list (#2607) Make explicit the cause of failure in this case.
benjaminhwilliams
pushed a commit
that referenced
this pull request
Feb 27, 2024
…flection list (#2607) Make explicit the cause of failure in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The situation that lead here is an attempt to index a sparse pattern using 2 images only, separated widely in phi. These images represent two separate experiments, but we are jointly indexing one crystal model. As indexing progresses in macrocycles, one image becomes favoured, and the spots on the other image are no longer being indexed. Eventually no indexed spots are left on the weaker image.
Possibly in this case we should continue anyway and just throw out the bad image. However, at the very least we can fail with an appropriate error message. This PR adds that message, rather than failing with a related but confusing message later.