Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin gemmi version #2618

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Unpin gemmi version #2618

merged 2 commits into from
Feb 29, 2024

Conversation

jbeilstenedmands
Copy link
Contributor

Gemmi 0.6.5 fixes an issue encountered on windows, so unpin. See #2578 for more details.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (d2f8e5f) to head (8eba689).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2618   +/-   ##
=======================================
  Coverage   78.40%   78.41%           
=======================================
  Files         610      610           
  Lines       75322    75322           
  Branches    10745    10745           
=======================================
+ Hits        59057    59061    +4     
+ Misses      14092    14088    -4     
  Partials     2173     2173           

@ndevenish ndevenish merged commit f18f8af into main Feb 29, 2024
17 of 18 checks passed
@ndevenish ndevenish deleted the unpin_gemmi branch February 29, 2024 11:36
jbeilstenedmands added a commit to jbeilstenedmands/dials that referenced this pull request Mar 8, 2024
* Unpin gemmi version, now that windows issue has been resolved

* Rename newsfragments/XXX.misc to newsfragments/2618.misc

---------

Co-authored-by: DiamondLightSource-build-server <DiamondLightSource-build-server@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants