Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dials.predict ignore_shadows=False is broken #2630

Open
dagewa opened this issue Mar 13, 2024 · 0 comments
Open

dials.predict ignore_shadows=False is broken #2630

dagewa opened this issue Mar 13, 2024 · 0 comments

Comments

@dagewa
Copy link
Member

dagewa commented Mar 13, 2024

          @graeme-winter I tried testing this with any old data set:
dials.predict $(dials.data get -q centroid_test_data)/indexed.expt ignore_shadows=False
The following parameters have been modified:

ignore_shadows = False
input {
  experiments = /home/fcx32934/sw/cctbx/build/dials_data/centroid_test_data/indexed.expt
}

Traceback (most recent call last):
  File "/home/fcx32934/sw/cctbx/build/../modules/dials/src/dials/command_line/predict.py", line 141, in <module>
    run()
  File "/home/fcx32934/sw/cctbx/conda_base/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/home/fcx32934/sw/cctbx/build/../modules/dials/src/dials/command_line/predict.py", line 137, in run
    script.run(args)
  File "/home/fcx32934/sw/cctbx/build/../modules/dials/src/dials/command_line/predict.py", line 118, in run
    shadowed = filter_shadowed_reflections(
  File "/home/fcx32934/sw/cctbx/modules/dials/src/dials/algorithms/shadowing/filter.py", line 19, in filter_shadowed_reflections
    shadow = masker.project_extrema(
AttributeError: Please report this error to dials-support@lists.sourceforge.net: 'NoneType' object has no attribute 'project_extrema'

Seems to me that the shadowing stuff you added is broken? This error is the same on main.

Originally posted by @dagewa in #2553 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant