Unused parameter nthreads #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
===========================================
+ Coverage 78.33% 90.67% +12.34%
===========================================
Files 611 282 -329
Lines 75386 25721 -49665
Branches 10767 2297 -8470
===========================================
- Hits 59052 23322 -35730
+ Misses 14149 2291 -11858
+ Partials 2185 108 -2077 |
amyjaynethompson
pushed a commit
to amyjaynethompson/dials
that referenced
this pull request
Apr 24, 2024
* Unused parameter nthreads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the help request I found that there is an unused and unsupported parameter in the API => propose removing as it is misleading